diff options
| author | Vincent BENAYOUN <vincent.benayoun@trust-in-soft.com> | 2014-11-13 15:47:26 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2014-11-15 01:08:58 +0300 |
| commit | 84bc88688e3f6ef843aa8803dbcd90168bb89faf (patch) | |
| tree | ca917b50323869b5821f46ca6e0d901d0a6053f9 /include/linux/inetdevice.h | |
| parent | b23dc5a7cc6ebc9a0d57351da7a0e8454c9ffea3 (diff) | |
| download | linux-84bc88688e3f6ef843aa8803dbcd90168bb89faf.tar.xz | |
inetdevice: fixed signed integer overflow
There could be a signed overflow in the following code.
The expression, (32-logmask) is comprised between 0 and 31 included.
It may be equal to 31.
In such a case the left shift will produce a signed integer overflow.
According to the C99 Standard, this is an undefined behavior.
A simple fix is to replace the signed int 1 with the unsigned int 1U.
Signed-off-by: Vincent BENAYOUN <vincent.benayoun@trust-in-soft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/inetdevice.h')
| -rw-r--r-- | include/linux/inetdevice.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/inetdevice.h b/include/linux/inetdevice.h index 0068708161ff..0a21fbefdfbe 100644 --- a/include/linux/inetdevice.h +++ b/include/linux/inetdevice.h @@ -242,7 +242,7 @@ static inline void in_dev_put(struct in_device *idev) static __inline__ __be32 inet_make_mask(int logmask) { if (logmask) - return htonl(~((1<<(32-logmask))-1)); + return htonl(~((1U<<(32-logmask))-1)); return 0; } |