diff options
| author | KP Singh <kpsingh@kernel.org> | 2022-04-18 18:51:58 +0300 |
|---|---|---|
| committer | Alexei Starovoitov <ast@kernel.org> | 2022-04-20 03:55:45 +0300 |
| commit | dcf456c9a095a6e71f53d6f6f004133ee851ee70 (patch) | |
| tree | 9050bc91c5fb6751e8ab4a6076837645ef34dd19 /include/linux/bpf_local_storage.h | |
| parent | 0e5aefa334dba7fc07ee4ef52ae622f957fc865b (diff) | |
| download | linux-dcf456c9a095a6e71f53d6f6f004133ee851ee70.tar.xz | |
bpf: Fix usage of trace RCU in local storage.
bpf_{sk,task,inode}_storage_free() do not need to use
call_rcu_tasks_trace as no BPF program should be accessing the owner
as it's being destroyed. The only other reader at this point is
bpf_local_storage_map_free() which uses normal RCU.
The only path that needs trace RCU are:
* bpf_local_storage_{delete,update} helpers
* map_{delete,update}_elem() syscalls
Fixes: 0fe4b381a59e ("bpf: Allow bpf_local_storage to be used by sleepable programs")
Signed-off-by: KP Singh <kpsingh@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/20220418155158.2865678-1-kpsingh@kernel.org
Diffstat (limited to 'include/linux/bpf_local_storage.h')
| -rw-r--r-- | include/linux/bpf_local_storage.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/bpf_local_storage.h b/include/linux/bpf_local_storage.h index 493e63258497..7ea18d4da84b 100644 --- a/include/linux/bpf_local_storage.h +++ b/include/linux/bpf_local_storage.h @@ -143,9 +143,9 @@ void bpf_selem_link_storage_nolock(struct bpf_local_storage *local_storage, bool bpf_selem_unlink_storage_nolock(struct bpf_local_storage *local_storage, struct bpf_local_storage_elem *selem, - bool uncharge_omem); + bool uncharge_omem, bool use_trace_rcu); -void bpf_selem_unlink(struct bpf_local_storage_elem *selem); +void bpf_selem_unlink(struct bpf_local_storage_elem *selem, bool use_trace_rcu); void bpf_selem_link_map(struct bpf_local_storage_map *smap, struct bpf_local_storage_elem *selem); |