diff options
author | Cliff Wickman <cpw@sgi.com> | 2010-12-13 19:51:57 +0300 |
---|---|---|
committer | H. Peter Anvin <hpa@linux.intel.com> | 2010-12-28 01:02:11 +0300 |
commit | c8217b8305e5e75c23617f2f4cd262527d952c0a (patch) | |
tree | b7bc356f5021cbbb21ee24d00c9e94f03f6d35c4 /include/asm-generic/pgtable-nopud.h | |
parent | 90a8a73c06cc32b609a880d48449d7083327e11a (diff) | |
download | linux-c8217b8305e5e75c23617f2f4cd262527d952c0a.tar.xz |
x86, paravirt: Use native_halt on a halt, not native_safe_halt
halt() should use native_halt()
safe_halt() uses native_safe_halt()
If CONFIG_PARAVIRT=y, halt() is defined in arch/x86/include/asm/paravirt.h as
static inline void halt(void)
{
PVOP_VCALL0(pv_irq_ops.safe_halt);
}
Otherwise (no CONFIG_PARAVIRT) halt() in arch/x86/include/asm/irqflags.h is
static inline void halt(void)
{
native_halt();
}
So it looks to me like the CONFIG_PARAVIRT case of using native_safe_halt()
for a halt() is an oversight.
Am I missing something?
It probably hasn't shown up as a problem because the local apic is disabled
on a shutdown or restart. But if we disable interrupts and call halt()
we shouldn't expect that the halt() will re-enable interrupts.
Signed-off-by: Cliff Wickman <cpw@sgi.com>
LKML-Reference: <E1PSBcz-0001g1-FM@eag09.americas.sgi.com>
Signed-off-by: H. Peter Anvin <hpa@linux.intel.com>
Diffstat (limited to 'include/asm-generic/pgtable-nopud.h')
0 files changed, 0 insertions, 0 deletions