diff options
| author | Gustavo A. R. Silva <gustavo@embeddedor.com> | 2018-10-10 01:02:20 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2018-10-24 05:16:05 +0300 |
| commit | f70556c8cae976e50ba9c27dd4c1a86b57efc17d (patch) | |
| tree | 0ca911e66f6d752b376539bf07dd0db782450019 /fs | |
| parent | f5b05d622a3e99e6a97a189fe500414be802a05c (diff) | |
| download | linux-f70556c8cae976e50ba9c27dd4c1a86b57efc17d.tar.xz | |
smb2: fix uninitialized variable bug in smb2_ioctl_query_info
There is a potential execution path in which variable *resp_buftype*
is passed as an argument to function free_rsp_buf(), in which it is
used in a comparison without being properly initialized previously.
Fix this by initializing variable *resp_buftype* to CIFS_NO_BUFFER
in order to avoid unpredictable or unintended results.
Addresses-Coverity-ID: 1473971 ("Uninitialized scalar variable")
Fixes: c5d25bdb2967 ("cifs: add IOCTL for QUERY_INFO passthrough to userspace")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/smb2ops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index c6c6450d0f38..8472cb0ae06c 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -1133,7 +1133,7 @@ smb2_ioctl_query_info(const unsigned int xid, struct smb_rqst rqst; struct kvec iov[1]; struct kvec rsp_iov; - int resp_buftype; + int resp_buftype = CIFS_NO_BUFFER; struct smb2_query_info_rsp *rsp = NULL; void *buffer; |