diff options
| author | Jan Kara <jack@suse.cz> | 2024-01-09 14:27:44 +0300 |
|---|---|---|
| committer | Jan Kara <jack@suse.cz> | 2024-01-23 21:21:11 +0300 |
| commit | c3e637c7f0c9aea051b3e49fc243ad83e19348c6 (patch) | |
| tree | 0cd99a04eacbb3385bad5261e2c1d6cf4b9ffe95 /fs | |
| parent | 36975616ea5837955ce9bbe84095680c940fe025 (diff) | |
| download | linux-c3e637c7f0c9aea051b3e49fc243ad83e19348c6.tar.xz | |
ext2: Remove GFP_NOFS use in ext2_xattr_cache_insert()
ext2_xattr_cache_insert() calls mb_cache_entry_create() with GFP_NOFS
because it is called under EXT2_I(inode)->xattr_sem. However xattr_sem
or any higher ranking lock is not acquired on fs reclaim path for ext2
at least since we don't do page writeback from direct reclaim. Thus
GFP_NOFS is not needed.
Signed-off-by: Jan Kara <jack@suse.cz>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/ext2/xattr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext2/xattr.c b/fs/ext2/xattr.c index e849241ebb8f..c885dcc3bd0d 100644 --- a/fs/ext2/xattr.c +++ b/fs/ext2/xattr.c @@ -874,7 +874,7 @@ ext2_xattr_cache_insert(struct mb_cache *cache, struct buffer_head *bh) __u32 hash = le32_to_cpu(HDR(bh)->h_hash); int error; - error = mb_cache_entry_create(cache, GFP_NOFS, hash, bh->b_blocknr, + error = mb_cache_entry_create(cache, GFP_KERNEL, hash, bh->b_blocknr, true); if (error) { if (error == -EBUSY) { |