diff options
author | Brian Foster <bfoster@redhat.com> | 2018-07-12 08:26:22 +0300 |
---|---|---|
committer | Darrick J. Wong <darrick.wong@oracle.com> | 2018-07-12 08:26:22 +0300 |
commit | 766139032f95bb41031f6de9c2ee0538bd035229 (patch) | |
tree | dc21b2a2b9a56c8ea4dabc3362fccb065e857605 /fs/xfs/xfs_dquot.c | |
parent | 825d75cd8c1b53883dd8c2fe1d8833c371b08074 (diff) | |
download | linux-766139032f95bb41031f6de9c2ee0538bd035229.tar.xz |
xfs: use ->t_firstblock in xattr ops
Similar to the dirops code, the xattr code uses an on-stack
firstblock variable for the various operations. This code rolls the
underlying transaction in various places, however, which means we
cannot simply replace the local firstblock vars with ->t_firstblock.
Doing so (without further changes) would invalidate the memory
pointed to by xfs_da_args.firstblock as soon as the first
transaction rolls.
To avoid this problem, remove xfs_da_args.firstblock and replace all
such accesses with ->t_firstblock at the same time. This ensures
that accesses to the current firstblock always occur through the
current transaction rather than a potentially invalid xfs_da_args
pointer.
Signed-off-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Diffstat (limited to 'fs/xfs/xfs_dquot.c')
0 files changed, 0 insertions, 0 deletions