summaryrefslogtreecommitdiff
path: root/fs/proc
diff options
context:
space:
mode:
authorChristian Brauner <brauner@kernel.org>2024-08-06 19:02:32 +0300
committerChristian Brauner <brauner@kernel.org>2024-08-30 09:22:13 +0300
commitcf71eaa1ad18d6f6e130cda708300b587176f16f (patch)
tree5d925962d5938e465a7df913f5a19a0f633c18ec /fs/proc
parent74ce208089f468db26eddcc5ea58e50f5bbbc291 (diff)
downloadlinux-cf71eaa1ad18d6f6e130cda708300b587176f16f.tar.xz
proc: block mounting on top of /proc/<pid>/fdinfo/*
Entries under /proc/<pid>/fdinfo/* are ephemeral and may go away before the process dies. As such allowing them to be used as mount points creates the ability to leak mounts that linger until the process dies with no ability to unmount them until then. Don't allow using them as mountpoints. Link: https://lore.kernel.org/r/20240806-work-procfs-v1-6-fb04e1d09f0c@kernel.org Reviewed-by: Josef Bacik <josef@toxicpanda.com> Signed-off-by: Christian Brauner <brauner@kernel.org>
Diffstat (limited to 'fs/proc')
-rw-r--r--fs/proc/fd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/proc/fd.c b/fs/proc/fd.c
index 671a45884304..623780449c48 100644
--- a/fs/proc/fd.c
+++ b/fs/proc/fd.c
@@ -397,8 +397,8 @@ static struct dentry *proc_fdinfo_instantiate(struct dentry *dentry,
inode->i_fop = &proc_fdinfo_file_operations;
tid_fd_update_inode(task, inode, 0);
- d_set_d_op(dentry, &tid_fd_dentry_operations);
- return d_splice_alias(inode, dentry);
+ return proc_splice_unmountable(inode, dentry,
+ &tid_fd_dentry_operations);
}
static struct dentry *