summaryrefslogtreecommitdiff
path: root/fs/proc/fd.c
diff options
context:
space:
mode:
authorEric W. Biederman <ebiederm@xmission.com>2020-11-21 02:14:24 +0300
committerEric W. Biederman <ebiederm@xmission.com>2020-12-10 21:39:54 +0300
commitbebf684bf330915e6c96313ad7db89a5480fc9c2 (patch)
tree4ed67093e5244e8950ff31280000ee0ceea384f0 /fs/proc/fd.c
parent439be32656035d3239fd56f9b83353ec06cb3b45 (diff)
downloadlinux-bebf684bf330915e6c96313ad7db89a5480fc9c2.tar.xz
file: Rename __fcheck_files to files_lookup_fd_raw
The function fcheck despite it's comment is poorly named as it has no callers that only check it's return value. All of fcheck's callers use the returned file descriptor. The same is true for fcheck_files and __fcheck_files. A new less confusing name is needed. In addition the names of these functions are confusing as they do not report the kind of locks that are needed to be held when these functions are called making error prone to use them. To remedy this I am making the base functio name lookup_fd and will and prefixes and sufficies to indicate the rest of the context. Name the function (previously called __fcheck_files) that proceeds from a struct files_struct, looks up the struct file of a file descriptor, and requires it's callers to verify all of the appropriate locks are held files_lookup_fd_raw. The need for better names became apparent in the last round of discussion of this set of changes[1]. [1] https://lkml.kernel.org/r/CAHk-=wj8BQbgJFLa+J0e=iT-1qpmCRTbPAJ8gd6MJQ=kbRPqyQ@mail.gmail.com Link: https://lkml.kernel.org/r/20201120231441.29911-7-ebiederm@xmission.com Signed-off-by: Eric W. Biederman <ebiederm@xmission.com>
Diffstat (limited to 'fs/proc/fd.c')
0 files changed, 0 insertions, 0 deletions