diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2015-02-13 02:01:11 +0300 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2015-02-13 05:54:12 +0300 | 
| commit | edc924e023ae2022fc29f1246e115c610c9abf38 (patch) | |
| tree | 09417a3d57aa78bc11ae8a35d2aca4b0c627db1c /fs/proc/array.c | |
| parent | 198d1597cc5a12d04af18b69338a5b1d66ee7020 (diff) | |
| download | linux-edc924e023ae2022fc29f1246e115c610c9abf38.tar.xz | |
fs/proc/array.c: convert to use string_escape_str()
Instead of custom approach let's use string_escape_str() to escape a given
string (task_name in this case).
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/proc/array.c')
| -rw-r--r-- | fs/proc/array.c | 34 | 
1 files changed, 7 insertions, 27 deletions
| diff --git a/fs/proc/array.c b/fs/proc/array.c index bd117d065b82..a3ccf4c4ce70 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -81,6 +81,7 @@  #include <linux/pid_namespace.h>  #include <linux/ptrace.h>  #include <linux/tracehook.h> +#include <linux/string_helpers.h>  #include <linux/user_namespace.h>  #include <asm/pgtable.h> @@ -89,39 +90,18 @@  static inline void task_name(struct seq_file *m, struct task_struct *p)  { -	int i; -	char *buf, *end; -	char *name; +	char *buf;  	char tcomm[sizeof(p->comm)];  	get_task_comm(tcomm, p);  	seq_puts(m, "Name:\t"); -	end = m->buf + m->size;  	buf = m->buf + m->count; -	name = tcomm; -	i = sizeof(tcomm); -	while (i && (buf < end)) { -		unsigned char c = *name; -		name++; -		i--; -		*buf = c; -		if (!c) -			break; -		if (c == '\\') { -			buf++; -			if (buf < end) -				*buf++ = c; -			continue; -		} -		if (c == '\n') { -			*buf++ = '\\'; -			if (buf < end) -				*buf++ = 'n'; -			continue; -		} -		buf++; -	} + +	/* Ignore error for now */ +	string_escape_str(tcomm, &buf, m->size - m->count, +			  ESCAPE_SPACE | ESCAPE_SPECIAL, "\n\\"); +  	m->count = buf - m->buf;  	seq_putc(m, '\n');  } | 
