summaryrefslogtreecommitdiff
path: root/fs/gfs2/xattr.h
diff options
context:
space:
mode:
authorJ. Bruce Fields <bfields@redhat.com>2017-04-21 23:10:18 +0300
committerJ. Bruce Fields <bfields@redhat.com>2017-04-25 23:34:37 +0300
commite6838a29ecb484c97e4efef9429643b9851fba6e (patch)
tree81c1d063695048dfa7df8fce71b3a9aeeec64798 /fs/gfs2/xattr.h
parent5a7ad1146caa895ad718a534399e38bd2ba721b7 (diff)
downloadlinux-e6838a29ecb484c97e4efef9429643b9851fba6e.tar.xz
nfsd: check for oversized NFSv2/v3 arguments
A client can append random data to the end of an NFSv2 or NFSv3 RPC call without our complaining; we'll just stop parsing at the end of the expected data and ignore the rest. Encoded arguments and replies are stored together in an array of pages, and if a call is too large it could leave inadequate space for the reply. This is normally OK because NFS RPC's typically have either short arguments and long replies (like READ) or long arguments and short replies (like WRITE). But a client that sends an incorrectly long reply can violate those assumptions. This was observed to cause crashes. Also, several operations increment rq_next_page in the decode routine before checking the argument size, which can leave rq_next_page pointing well past the end of the page array, causing trouble later in svc_free_pages. So, following a suggestion from Neil Brown, add a central check to enforce our expectation that no NFSv2/v3 call has both a large call and a large reply. As followup we may also want to rewrite the encoding routines to check more carefully that they aren't running off the end of the page array. We may also consider rejecting calls that have any extra garbage appended. That would be safer, and within our rights by spec, but given the age of our server and the NFS protocol, and the fact that we've never enforced this before, we may need to balance that against the possibility of breaking some oddball client. Reported-by: Tuomas Haanpää <thaan@synopsys.com> Reported-by: Ari Kauppi <ari@synopsys.com> Cc: stable@vger.kernel.org Reviewed-by: NeilBrown <neilb@suse.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Diffstat (limited to 'fs/gfs2/xattr.h')
0 files changed, 0 insertions, 0 deletions