summaryrefslogtreecommitdiff
path: root/fs/f2fs/super.c
diff options
context:
space:
mode:
authorChao Yu <yuchao0@huawei.com>2019-09-27 13:01:35 +0300
committerJaegeuk Kim <jaegeuk@kernel.org>2019-10-04 23:32:32 +0300
commitfe1897eaa6646f5a64a4cee0e6473ed9887d324b (patch)
tree28aac9cc3953df67755ae28d22dde07aaed205fe /fs/f2fs/super.c
parentb145b0eb2031a620ca010174240963e4d2c6ce26 (diff)
downloadlinux-fe1897eaa6646f5a64a4cee0e6473ed9887d324b.tar.xz
f2fs: fix to update time in lazytime mode
generic/018 reports an inconsistent status of atime, the testcase is as below: - open file with O_SYNC - write file to construct fraged space - calc md5 of file - record {a,c,m}time - defrag file --- do nothing - umount & mount - check {a,c,m}time The root cause is, as f2fs enables lazytime by default, atime update will dirty vfs inode, rather than dirtying f2fs inode (by set with FI_DIRTY_INODE), so later f2fs_write_inode() called from VFS will fail to update inode page due to our skip: f2fs_write_inode() if (is_inode_flag_set(inode, FI_DIRTY_INODE)) return 0; So eventually, after evict(), we lose last atime for ever. To fix this issue, we need to check whether {a,c,m,cr}time is consistent in between inode cache and inode page, and only skip f2fs_update_inode() if f2fs inode is not dirty and time is consistent as well. Signed-off-by: Chao Yu <yuchao0@huawei.com> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/super.c')
0 files changed, 0 insertions, 0 deletions