diff options
author | Chao Yu <yuchao0@huawei.com> | 2018-02-25 18:38:21 +0300 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2018-03-13 02:05:47 +0300 |
commit | 17cd07ae95073c298af92c1ba14ac58ce84de33b (patch) | |
tree | c6fa92b6124fbe769f5ecb76a73bf70e6ce0f387 /fs/f2fs/namei.c | |
parent | d0d3f1b329b01a9e16609eeadcc6d4fae0afc7c8 (diff) | |
download | linux-17cd07ae95073c298af92c1ba14ac58ce84de33b.tar.xz |
f2fs: fix to set KEEP_SIZE bit in f2fs_zero_range
As Jayashree Mohan reported:
A simple workload to reproduce this would be :
1. create foo
2. Write (8K - 16K) // foo size = 16K now
3. fsync()
4. falloc zero_range , keep_size (4202496 - 4210688) // foo size must be 16K
5. fdatasync()
Crash now
On recovery, we see that the file size is 4210688 and not 16K, which
violates the semantics of keep_size flag. We have a test case to
reproduce this using CrashMonkey on 4.15 kernel. Try this out by
simply running :
./c_harness -f /dev/sda -d /dev/cow_ram0 -t f2fs -e 102400 -P -v
tests/generic_468_zero.so
The root cause is that we miss to set KEEP_SIZE bit correctly in zero_range
when zeroing block cross EOF with FALLOC_FL_KEEP_SIZE, let's fix this
missing case.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/namei.c')
0 files changed, 0 insertions, 0 deletions