diff options
| author | Ronnie Sahlberg <lsahlber@redhat.com> | 2019-06-05 03:38:38 +0300 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2019-06-13 22:21:09 +0300 |
| commit | 487317c99477d00f22370625d53be3239febabbe (patch) | |
| tree | a6da1276cdc7abd0870f9eda758115c8912f930e /fs/cifs/cifsfs.c | |
| parent | 0ff2b018b02f89da26a616e0148582321a00fd99 (diff) | |
| download | linux-487317c99477d00f22370625d53be3239febabbe.tar.xz | |
cifs: add spinlock for the openFileList to cifsInodeInfo
We can not depend on the tcon->open_file_lock here since in multiuser mode
we may have the same file/inode open via multiple different tcons.
The current code is race prone and will crash if one user deletes a file
at the same time a different user opens/create the file.
To avoid this we need to have a spinlock attached to the inode and not the tcon.
RHBZ: 1580165
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Diffstat (limited to 'fs/cifs/cifsfs.c')
| -rw-r--r-- | fs/cifs/cifsfs.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/cifs/cifsfs.c b/fs/cifs/cifsfs.c index f5fcd6360056..65d9771e49f9 100644 --- a/fs/cifs/cifsfs.c +++ b/fs/cifs/cifsfs.c @@ -303,6 +303,7 @@ cifs_alloc_inode(struct super_block *sb) cifs_inode->uniqueid = 0; cifs_inode->createtime = 0; cifs_inode->epoch = 0; + spin_lock_init(&cifs_inode->open_file_lock); generate_random_uuid(cifs_inode->lease_key); /* |