diff options
author | Oleg Nesterov <oleg@redhat.com> | 2013-12-14 20:33:17 +0400 |
---|---|---|
committer | Paul Moore <pmoore@redhat.com> | 2013-12-17 01:00:29 +0400 |
commit | 465954cd649a7d8cd331695bd24a16bcb5c4c716 (patch) | |
tree | 8c0e5ee5d4073fb24e4b58719488da578cfe49f8 /fs/char_dev.c | |
parent | a5e333d34037c64c5f667dee3c418b66874ba0b0 (diff) | |
download | linux-465954cd649a7d8cd331695bd24a16bcb5c4c716.tar.xz |
selinux: selinux_setprocattr()->ptrace_parent() needs rcu_read_lock()
selinux_setprocattr() does ptrace_parent(p) under task_lock(p),
but task_struct->alloc_lock doesn't pin ->parent or ->ptrace,
this looks confusing and triggers the "suspicious RCU usage"
warning because ptrace_parent() does rcu_dereference_check().
And in theory this is wrong, spin_lock()->preempt_disable()
doesn't necessarily imply rcu_read_lock() we need to access
the ->parent.
Reported-by: Evan McNabb <emcnabb@redhat.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Paul Moore <pmoore@redhat.com>
Diffstat (limited to 'fs/char_dev.c')
0 files changed, 0 insertions, 0 deletions