diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2021-03-12 23:25:20 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2021-04-19 18:25:21 +0300 |
| commit | 592fbcd50c99b8adf999a2a54f9245caff333139 (patch) | |
| tree | e339297d776f7b1b8a66d5cf65ece6fff09ae60e /fs/btrfs | |
| parent | bbae13f8ab22fb997403ee8a67f87432f4751a8d (diff) | |
| download | linux-592fbcd50c99b8adf999a2a54f9245caff333139.tar.xz | |
btrfs: do proper error handling in btrfs_update_reloc_root
We call btrfs_update_root in btrfs_update_reloc_root, which can fail for
all sorts of reasons, including IO errors. Instead of panicing the box
lets return the error, now that all callers properly handle those
errors.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs')
| -rw-r--r-- | fs/btrfs/relocation.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c index ca97412d7262..489097fbf9e2 100644 --- a/fs/btrfs/relocation.c +++ b/fs/btrfs/relocation.c @@ -903,7 +903,7 @@ int btrfs_update_reloc_root(struct btrfs_trans_handle *trans, int ret; if (!have_reloc_root(root)) - goto out; + return 0; reloc_root = root->reloc_root; root_item = &reloc_root->root_item; @@ -936,10 +936,8 @@ int btrfs_update_reloc_root(struct btrfs_trans_handle *trans, ret = btrfs_update_root(trans, fs_info->tree_root, &reloc_root->root_key, root_item); - BUG_ON(ret); btrfs_put_root(reloc_root); -out: - return 0; + return ret; } /* |