diff options
| author | Omar Sandoval <osandov@fb.com> | 2020-04-17 00:46:24 +0300 |
|---|---|---|
| committer | David Sterba <dsterba@suse.com> | 2020-05-25 12:25:27 +0300 |
| commit | 5c047a699aa9433ad92136343a9306d985134c24 (patch) | |
| tree | 6b50a96455fab869499f944b0f7d4cc4eecf013f /fs/btrfs/disk-io.h | |
| parent | fd9d6670edba68cedd87b3db04cbdcdfc492cc0a (diff) | |
| download | linux-5c047a699aa9433ad92136343a9306d985134c24.tar.xz | |
btrfs: get rid of endio_repair_workers
This was originally added in commit 8b110e393c5a ("Btrfs: implement
repair function when direct read fails") to avoid a deadlock. In that
commit, the direct I/O read endio executes on the endio_workers
workqueue, submits a repair bio, and waits for it to complete. The
repair bio endio must execute on a different workqueue, otherwise it
could block on the endio_workers workqueue becoming available, which
won't happen because the original endio is blocked on the repair bio.
As of the previous commit, the original endio doesn't wait for the
repair bio, so this separate workqueue is unnecessary.
Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Diffstat (limited to 'fs/btrfs/disk-io.h')
| -rw-r--r-- | fs/btrfs/disk-io.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/fs/btrfs/disk-io.h b/fs/btrfs/disk-io.h index cd629113f61c..734bc5270b6a 100644 --- a/fs/btrfs/disk-io.h +++ b/fs/btrfs/disk-io.h @@ -25,7 +25,6 @@ enum btrfs_wq_endio_type { BTRFS_WQ_ENDIO_METADATA, BTRFS_WQ_ENDIO_FREE_SPACE, BTRFS_WQ_ENDIO_RAID56, - BTRFS_WQ_ENDIO_DIO_REPAIR, }; static inline u64 btrfs_sb_offset(int mirror) |