summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorMoshe Shemesh <moshe@nvidia.com>2022-07-28 18:53:50 +0300
committerJakub Kicinski <kuba@kernel.org>2022-07-29 07:58:47 +0300
commitc90005b5f75ce3ef6170281ac4d77e8b7123995b (patch)
tree2bcdffb20146a6fcd7debe47874f9c0c26aef6d7 /drivers
parentd3dbdc9f8ddce46ae2646b2257106d8cdb3d5887 (diff)
downloadlinux-c90005b5f75ce3ef6170281ac4d77e8b7123995b.tar.xz
devlink: Hold the instance lock in health callbacks
Let the core take the devlink instance lock around health callbacks and remove the now redundant locking in the drivers. Signed-off-by: Moshe Shemesh <moshe@nvidia.com> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/ethernet/mellanox/mlx5/core/health.c8
1 files changed, 1 insertions, 7 deletions
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/health.c b/drivers/net/ethernet/mellanox/mlx5/core/health.c
index 6e154b5c2bc6..2cf2c9948446 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/health.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/health.c
@@ -622,14 +622,8 @@ mlx5_fw_fatal_reporter_recover(struct devlink_health_reporter *reporter,
struct netlink_ext_ack *extack)
{
struct mlx5_core_dev *dev = devlink_health_reporter_priv(reporter);
- struct devlink *devlink = priv_to_devlink(dev);
- int ret;
- devl_lock(devlink);
- ret = mlx5_health_try_recover(dev);
- devl_unlock(devlink);
-
- return ret;
+ return mlx5_health_try_recover(dev);
}
static int