summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorJack Wang <jinpu.wang@ionos.com>2022-08-26 13:13:35 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-10-24 10:58:02 +0300
commit908bfb4f5ff88dc1a85820110a38e6ba9082ff2b (patch)
tree3c241ab945f9f3e78c3f8763068e0db79c28bfae /drivers
parentadc15eefb41770433e1c80cda92bdf58fb6ab0c1 (diff)
downloadlinux-908bfb4f5ff88dc1a85820110a38e6ba9082ff2b.tar.xz
mailbox: bcm-ferxrm-mailbox: Fix error check for dma_map_sg
[ Upstream commit 6b207ce8a96a71e966831e3a13c38143ba9a73c1 ] dma_map_sg return 0 on error, fix the error check, and return -EIO to caller. Fixes: dbc049eee730 ("mailbox: Add driver for Broadcom FlexRM ring manager") Signed-off-by: Jack Wang <jinpu.wang@ionos.com> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/mailbox/bcm-flexrm-mailbox.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c
index 22acb51531cb..658e47b21933 100644
--- a/drivers/mailbox/bcm-flexrm-mailbox.c
+++ b/drivers/mailbox/bcm-flexrm-mailbox.c
@@ -632,15 +632,15 @@ static int flexrm_spu_dma_map(struct device *dev, struct brcm_message *msg)
rc = dma_map_sg(dev, msg->spu.src, sg_nents(msg->spu.src),
DMA_TO_DEVICE);
- if (rc < 0)
- return rc;
+ if (!rc)
+ return -EIO;
rc = dma_map_sg(dev, msg->spu.dst, sg_nents(msg->spu.dst),
DMA_FROM_DEVICE);
- if (rc < 0) {
+ if (!rc) {
dma_unmap_sg(dev, msg->spu.src, sg_nents(msg->spu.src),
DMA_TO_DEVICE);
- return rc;
+ return -EIO;
}
return 0;