summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorGUO Zihua <guozihua@huawei.com>2022-09-02 11:15:50 +0300
committerJakub Kicinski <kuba@kernel.org>2022-09-03 07:19:14 +0300
commit7b620e156097028e4c9b6481a84ec1e1e72877ca (patch)
tree2a163309ecbc011f1904c60d412003e9d8cbcb38 /drivers
parent0dbaf0fa62329d9fe452d9041a707a33f6274f1f (diff)
downloadlinux-7b620e156097028e4c9b6481a84ec1e1e72877ca.tar.xz
net: sunplus: Fix return type for implementation of ndo_start_xmit
Since Linux now supports CFI, it will be a good idea to fix mismatched return type for implementation of hooks. Otherwise this might get cought out by CFI and cause a panic. spl2sw_ethernet_start_xmit() would return either NETDEV_TX_BUSY or NETDEV_TX_OK, so change the return type to netdev_tx_t directly. Signed-off-by: GUO Zihua <guozihua@huawei.com> Link: https://lore.kernel.org/r/20220902081550.60095-1-guozihua@huawei.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/ethernet/sunplus/spl2sw_driver.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.c b/drivers/net/ethernet/sunplus/spl2sw_driver.c
index 546206640492..38e478aa415c 100644
--- a/drivers/net/ethernet/sunplus/spl2sw_driver.c
+++ b/drivers/net/ethernet/sunplus/spl2sw_driver.c
@@ -62,7 +62,8 @@ static int spl2sw_ethernet_stop(struct net_device *ndev)
return 0;
}
-static int spl2sw_ethernet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
+static netdev_tx_t spl2sw_ethernet_start_xmit(struct sk_buff *skb,
+ struct net_device *ndev)
{
struct spl2sw_mac *mac = netdev_priv(ndev);
struct spl2sw_common *comm = mac->comm;