diff options
author | Uday Shankar <ushankar@purestorage.com> | 2023-03-01 03:06:55 +0300 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2023-03-03 07:00:20 +0300 |
commit | 49d24398327e32265eccdeec4baeb5a6a609c0bd (patch) | |
tree | eac5516659021cb104b90d7b398f18843ff84d8a /drivers | |
parent | 326ac2c5133e5da7ccdd08d4f9c562f2323021aa (diff) | |
download | linux-49d24398327e32265eccdeec4baeb5a6a609c0bd.tar.xz |
blk-mq: enforce op-specific segment limits in blk_insert_cloned_request
The block layer might merge together discard requests up until the
max_discard_segments limit is hit, but blk_insert_cloned_request checks
the segment count against max_segments regardless of the req op. This
can result in errors like the following when discards are issued through
a DM device and max_discard_segments exceeds max_segments for the queue
of the chosen underlying device.
blk_insert_cloned_request: over max segments limit. (256 > 129)
Fix this by looking at the req_op and enforcing the appropriate segment
limit - max_discard_segments for REQ_OP_DISCARDs and max_segments for
everything else.
Signed-off-by: Uday Shankar <ushankar@purestorage.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20230301000655.48112-1-ushankar@purestorage.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers')
0 files changed, 0 insertions, 0 deletions