diff options
author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-11-06 18:48:10 +0300 |
---|---|---|
committer | Wim Van Sebroeck <wim@linux-watchdog.org> | 2023-12-17 18:14:19 +0300 |
commit | de81f74b11e9ffdf5362961c2efea13bef11aefd (patch) | |
tree | c92d262cb6adab6f9a37fa52e7b8c596e5c29ab1 /drivers/watchdog/imx2_wdt.c | |
parent | 86aa2919f1ae4ee7f90260d028f7572263d1c715 (diff) | |
download | linux-de81f74b11e9ffdf5362961c2efea13bef11aefd.tar.xz |
watchdog: txx9: Stop using module_platform_driver_probe()
On today's platforms the benefit of platform_driver_probe() isn't that
relevant any more. It allows to drop some code after booting (or module
loading) for .probe() and discard the .remove() function completely if
the driver is built-in. This typically saves a few 100k.
The downside of platform_driver_probe() is that the driver cannot be
bound and unbound at runtime which is ancient and also slightly
complicates testing. There are also thoughts to deprecate
platform_driver_probe() because it adds some complexity in the driver
core for little gain. Also many drivers don't use it correctly. This
driver for example misses to mark the driver struct with __refdata which
is needed to suppress a (W=1) modpost warning:
WARNING: modpost: drivers/watchdog/txx9wdt: section mismatch in reference: txx9wdt_driver+0x4 (section: .data) -> txx9wdt_remove (section: .exit.text)
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231106154807.3866712-3-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Diffstat (limited to 'drivers/watchdog/imx2_wdt.c')
0 files changed, 0 insertions, 0 deletions