diff options
author | Jean Delvare <jdelvare@suse.de> | 2018-02-03 13:25:20 +0300 |
---|---|---|
committer | Jean Delvare <jdelvare@suse.de> | 2018-02-03 13:25:20 +0300 |
commit | a7770ae194569e96a93c48aceb304edded9cc648 (patch) | |
tree | 90cb465ea86fb1f3c455b90e1f71739511bb735a /drivers/vme | |
parent | 7117794feb1602ea5efca1c7bfd5b78c3278d29d (diff) | |
download | linux-a7770ae194569e96a93c48aceb304edded9cc648.tar.xz |
firmware: dmi_scan: Fix handling of empty DMI strings
The handling of empty DMI strings looks quite broken to me:
* Strings from 1 to 7 spaces are not considered empty.
* True empty DMI strings (string index set to 0) are not considered
empty, and result in allocating a 0-char string.
* Strings with invalid index also result in allocating a 0-char
string.
* Strings starting with 8 spaces are all considered empty, even if
non-space characters follow (sounds like a weird thing to do, but
I have actually seen occurrences of this in DMI tables before.)
* Strings which are considered empty are reported as 8 spaces,
instead of being actually empty.
Some of these issues are the result of an off-by-one error in memcmp,
the rest is incorrect by design.
So let's get it square: missing strings and strings made of only
spaces, regardless of their length, should be treated as empty and
no memory should be allocated for them. All other strings are
non-empty and should be allocated.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Fixes: 79da4721117f ("x86: fix DMI out of memory problems")
Cc: Parag Warudkar <parag.warudkar@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Diffstat (limited to 'drivers/vme')
0 files changed, 0 insertions, 0 deletions