diff options
| author | Zheyu Ma <zheyuma97@gmail.com> | 2022-04-04 11:47:18 +0300 |
|---|---|---|
| committer | Helge Deller <deller@gmx.de> | 2022-04-11 09:23:49 +0300 |
| commit | 85ec038b53faec11baefb2c42b6c0ce8bec94d3e (patch) | |
| tree | be19597c03ac04ff666cbd2ab91d17fbe37aff6c /drivers/video | |
| parent | 836ffc47fa245e58cae51ac40c5ef71be8f4d480 (diff) | |
| download | linux-85ec038b53faec11baefb2c42b6c0ce8bec94d3e.tar.xz | |
video: fbdev: neofb: Fix the check of 'var->pixclock'
The previous check against 'var->pixclock' doesn't return -EINVAL when
it equals zero, but the driver uses it again, causing the divide error.
Fix this by returning when 'var->pixclock' is zero.
The following log reveals it:
divide error: 0000 [#1] PREEMPT SMP KASAN PTI
RIP: 0010:neofb_set_par+0x190f/0x49a0
Call Trace:
<TASK>
fb_set_var+0x604/0xeb0
do_fb_ioctl+0x234/0x670
fb_ioctl+0xdd/0x130
do_syscall_64+0x3b/0x90
Signed-off-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/fbdev/neofb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/fbdev/neofb.c b/drivers/video/fbdev/neofb.c index 966df2a07360..28d32cbf496b 100644 --- a/drivers/video/fbdev/neofb.c +++ b/drivers/video/fbdev/neofb.c @@ -585,7 +585,7 @@ neofb_check_var(struct fb_var_screeninfo *var, struct fb_info *info) DBG("neofb_check_var"); - if (var->pixclock && PICOS2KHZ(var->pixclock) > par->maxClock) + if (!var->pixclock || PICOS2KHZ(var->pixclock) > par->maxClock) return -EINVAL; /* Is the mode larger than the LCD panel? */ |