diff options
| author | Lee Jones <lee.jones@linaro.org> | 2020-07-06 16:33:34 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-07-09 18:19:58 +0300 |
| commit | beb368a4b9cbe67894354b884fa34e8e2e701a92 (patch) | |
| tree | d3454c719e1bfdc98b00cab848049eec79ed0dfd /drivers/usb/early | |
| parent | e6b073dea39bd8bfb02e05f46f27d94dc006e91c (diff) | |
| download | linux-beb368a4b9cbe67894354b884fa34e8e2e701a92.tar.xz | |
usb: early: ehci-dbgp: Remove set but never checked variable 'ret'
'ret' hasn't been checked since the driver's inception in 2009.
Fixes the following W=1 kernel build warning(s):
drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:
drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable]
915 | int chunk, ret;
| ^~~
Cc: Sumit Garg <sumit.garg@linaro.org>
Cc: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Link: https://lore.kernel.org/r/20200706133341.476881-26-lee.jones@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/early')
| -rw-r--r-- | drivers/usb/early/ehci-dbgp.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/usb/early/ehci-dbgp.c b/drivers/usb/early/ehci-dbgp.c index 775cf70cfb3e..b075dbfad730 100644 --- a/drivers/usb/early/ehci-dbgp.c +++ b/drivers/usb/early/ehci-dbgp.c @@ -912,7 +912,7 @@ int __init early_dbgp_init(char *s) static void early_dbgp_write(struct console *con, const char *str, u32 n) { - int chunk, ret; + int chunk; char buf[DBGP_MAX_PACKET]; int use_cr = 0; u32 cmd, ctrl; @@ -951,8 +951,8 @@ static void early_dbgp_write(struct console *con, const char *str, u32 n) buf[chunk] = *str; } if (chunk > 0) { - ret = dbgp_bulk_write(USB_DEBUG_DEVNUM, - dbgp_endpoint_out, buf, chunk); + dbgp_bulk_write(USB_DEBUG_DEVNUM, + dbgp_endpoint_out, buf, chunk); } } if (unlikely(reset_run)) { |