summaryrefslogtreecommitdiff
path: root/drivers/tty/serial/mps2-uart.c
diff options
context:
space:
mode:
authorNathan Chancellor <natechancellor@gmail.com>2019-01-31 21:06:28 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-01-31 21:34:10 +0300
commit9c6a2583f115acf29a27709ca9ce37714d04fb24 (patch)
tree18a473f2a6e886172d2adb390981827989a4224e /drivers/tty/serial/mps2-uart.c
parent7ab57b76ebf632bf2231ccabe26bea33868118c6 (diff)
downloadlinux-9c6a2583f115acf29a27709ca9ce37714d04fb24.tar.xz
serial: mps2-uart: Add parentheses around conditional in mps2_uart_shutdown
Clang warns: drivers/tty/serial/mps2-uart.c:351:6: warning: logical not is only applied to the left hand side of this bitwise operator [-Wlogical-not-parentheses] if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { ^ ~ drivers/tty/serial/mps2-uart.c:351:6: note: add parentheses after the '!' to evaluate the bitwise operator first if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { ^ ( ) drivers/tty/serial/mps2-uart.c:351:6: note: add parentheses around left hand side expression to silence this warning if (!mps_port->flags & UART_PORT_COMBINED_IRQ) { ^ ( ) 1 warning generated. As it was intended for this check to be the inverse of the one at the bottom of mps2_init_port, add parentheses around the whole conditional. Fixes: 775ea4ea2fd9 ("serial: mps2-uart: support combined irq") Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Vladimir Murzin <vladimir.murzin@arm.com> Link: https://github.com/ClangBuiltLinux/linux/issues/344 Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/serial/mps2-uart.c')
-rw-r--r--drivers/tty/serial/mps2-uart.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/serial/mps2-uart.c b/drivers/tty/serial/mps2-uart.c
index 4404eb7d118f..587b42f754cb 100644
--- a/drivers/tty/serial/mps2-uart.c
+++ b/drivers/tty/serial/mps2-uart.c
@@ -348,7 +348,7 @@ static void mps2_uart_shutdown(struct uart_port *port)
mps2_uart_write8(port, control, UARTn_CTRL);
- if (!mps_port->flags & UART_PORT_COMBINED_IRQ) {
+ if (!(mps_port->flags & UART_PORT_COMBINED_IRQ)) {
free_irq(mps_port->rx_irq, mps_port);
free_irq(mps_port->tx_irq, mps_port);
}