Merge tag 'spi-v6.7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi

Pull spi updates from Mark Brown:
 "This is a very quiet release for SPI, we've got cleanups and minor
  fixes but only a few new driver specific features. The bulk of the
  changes in terms of diffstat are the cleanups, plus one bit of
  performance work for McSPI.

   - Conversions to use devm_clk_get_enabled() and to remove outdated
     terms for controller and device

   - Device mode support for the Renesas CSI

   - Cleanups and improvements to the device tree bindings aimed at
     making validation better

   - PIO FIFO usage for the OMAP2 McSPI, improving performance"

* tag 'spi-v6.7' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi: (75 commits)
  spi: omap2-mcspi: Add FIFO support without DMA
  spi: stm32: Explicitly include correct DT includes
  spi: Export acpi_spi_find_controller_by_adev()
  spi: nxp-fspi: use the correct ioremap function
  spi: Don't use flexible array in struct spi_message definition
  spi: bcm2835: add a sentinel at the end of the lookup array
  spi: spi-geni-qcom: Rename the label unmap_if_dma
  spi: rzv2m-csi: Add target mode support
  spi: renesas,rzv2m-csi: Add CSI (SPI) target related property
  spi: spidev: make spidev_class constant
  spi: mpc52xx-psc: Make mpc52xx_psc_spi_transfer_one_message() static
  spi: spi-cadence-quadspi: Fix missing unwind goto warnings
  spi: omap2-mcspi: Fix hardcoded reference clock
  spi: dt-bindings: Make "additionalProperties: true" explicit
  spi: at91-usart: Remove some dead code
  spi: dt-bindings: st,stm32-spi: Move "st,spi-midi-ns" to spi-peripheral-props.yaml
  spi: qup: Vote for interconnect bandwidth to DRAM
  spi: dt-bindings: qup: Document interconnects
  spi: qup: Parse OPP table for DVFS support
  spi: dt-bindings: qup: Document power-domains and OPP
  ...

1 files changed, 4 insertions, 19 deletions

diff --git a/drivers/spi/spi-bcm2835aux.c b/drivers/spi/spi-bcm2835aux.c
index 6d2a5d9f2498..06fe155a70c9 100644
--- a/drivers/spi/spi-bcm2835aux.c
+++ b/drivers/spi/spi-bcm2835aux.c
@@ -512,7 +512,7 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev)
 	if (IS_ERR(bs->regs))
 		return PTR_ERR(bs->regs);
 
-	bs->clk = devm_clk_get(&pdev->dev, NULL);
+	bs->clk = devm_clk_get_enabled(&pdev->dev, NULL);
 	if (IS_ERR(bs->clk)) {
 		err = PTR_ERR(bs->clk);
 		dev_err(&pdev->dev, "could not get clk: %d\n", err);
@@ -523,19 +523,11 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev)
 	if (bs->irq < 0)
 		return bs->irq;
 
-	/* this also enables the HW block */
-	err = clk_prepare_enable(bs->clk);
-	if (err) {
-		dev_err(&pdev->dev, "could not prepare clock: %d\n", err);
-		return err;
-	}
-
 	/* just checking if the clock returns a sane value */
 	clk_hz = clk_get_rate(bs->clk);
 	if (!clk_hz) {
 		dev_err(&pdev->dev, "clock returns 0 Hz\n");
-		err = -ENODEV;
-		goto out_clk_disable;
+		return -ENODEV;
 	}
 
 	/* reset SPI-HW block */
@@ -547,22 +539,18 @@ static int bcm2835aux_spi_probe(struct platform_device *pdev)
 			       dev_name(&pdev->dev), host);
 	if (err) {
 		dev_err(&pdev->dev, "could not request IRQ: %d\n", err);
-		goto out_clk_disable;
+		return err;
 	}
 
 	err = spi_register_controller(host);
 	if (err) {
 		dev_err(&pdev->dev, "could not register SPI host: %d\n", err);
-		goto out_clk_disable;
+		return err;
 	}
 
 	bcm2835aux_debugfs_create(bs, dev_name(&pdev->dev));
 
 	return 0;
-
-out_clk_disable:
-	clk_disable_unprepare(bs->clk);
-	return err;
 }
 
 static void bcm2835aux_spi_remove(struct platform_device *pdev)
@@ -575,9 +563,6 @@ static void bcm2835aux_spi_remove(struct platform_device *pdev)
 	spi_unregister_controller(host);
 
 	bcm2835aux_spi_reset_hw(bs);
-
-	/* disable the HW block by releasing the clock */
-	clk_disable_unprepare(bs->clk);
 }
 
 static const struct of_device_id bcm2835aux_spi_match[] = {