diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2023-03-11 01:41:27 +0300 |
|---|---|---|
| committer | Li Yang <leoyang.li@nxp.com> | 2023-05-31 02:58:43 +0300 |
| commit | c27ea8e6325cad44c8c5bc2e8e7cc7635f358f31 (patch) | |
| tree | e1aad796539157cdaccefa9e69a6a6420a23a12d /drivers/soc | |
| parent | b3134039c5b3cf879841e3ec84c8cbf7675554ec (diff) | |
| download | linux-c27ea8e6325cad44c8c5bc2e8e7cc7635f358f31.tar.xz | |
soc: fsl: dpio: Suppress duplicated error reporting on device remove
Returning an error code from a fsl_mc_driver's remove callback results
in a generic error message, otherwise the value is ignored and the device
gets unbound.
As the only error path in dpaa2_dpio_remove() already emits an error
message, return zero unconditionally to suppress another (less helpful)
error report.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Tested-by: Ioana Ciornei <ioana.ciornei@nxp.com> # sanity checks
Reviewed-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Tested-by: Laurentiu Tudor <laurentiu.tudor@nxp.com>
Signed-off-by: Li Yang <leoyang.li@nxp.com>
Diffstat (limited to 'drivers/soc')
| -rw-r--r-- | drivers/soc/fsl/dpio/dpio-driver.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/soc/fsl/dpio/dpio-driver.c b/drivers/soc/fsl/dpio/dpio-driver.c index 74eace3109a1..09df5302d255 100644 --- a/drivers/soc/fsl/dpio/dpio-driver.c +++ b/drivers/soc/fsl/dpio/dpio-driver.c @@ -297,14 +297,10 @@ static int dpaa2_dpio_remove(struct fsl_mc_device *dpio_dev) dpio_close(dpio_dev->mc_io, 0, dpio_dev->mc_handle); - fsl_mc_portal_free(dpio_dev->mc_io); - - return 0; - err_open: fsl_mc_portal_free(dpio_dev->mc_io); - return err; + return 0; } static const struct fsl_mc_device_id dpaa2_dpio_match_id_table[] = { |