diff options
| author | Ming Lei <ming.lei@redhat.com> | 2022-03-14 07:30:18 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-03-14 23:05:41 +0300 |
| commit | daaca3522a8e67c46e39ef09c1d542e866f85f3b (patch) | |
| tree | f2e3ea824b72c3fe400e05162b6752e98bdd8012 /drivers/soc/samsung/Kconfig | |
| parent | 0a5aa8d161d19a1b12fd25b434b32f7c885c73bb (diff) | |
| download | linux-daaca3522a8e67c46e39ef09c1d542e866f85f3b.tar.xz | |
block: release rq qos structures for queue without disk
blkcg_init_queue() may add rq qos structures to request queue, previously
blk_cleanup_queue() calls rq_qos_exit() to release them, but commit
8e141f9eb803 ("block: drain file system I/O on del_gendisk")
moves rq_qos_exit() into del_gendisk(), so memory leak is caused
because queues may not have disk, such as un-present scsi luns, nvme
admin queue, ...
Fixes the issue by adding rq_qos_exit() to blk_cleanup_queue() back.
BTW, v5.18 won't need this patch any more since we move
blkcg_init_queue()/blkcg_exit_queue() into disk allocation/release
handler, and patches have been in for-5.18/block.
Cc: Christoph Hellwig <hch@lst.de>
Cc: stable@vger.kernel.org
Fixes: 8e141f9eb803 ("block: drain file system I/O on del_gendisk")
Reported-by: syzbot+b42749a851a47a0f581b@syzkaller.appspotmail.com
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20220314043018.177141-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/soc/samsung/Kconfig')
0 files changed, 0 insertions, 0 deletions