diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-10-11 15:36:38 +0300 |
|---|---|---|
| committer | Shawn Guo <shawnguo@kernel.org> | 2021-10-15 06:10:05 +0300 |
| commit | 72949f76565c9ea9f4231c977774a31d4713c386 (patch) | |
| tree | aa72019cee40c742722728fc88bb86b62c13879c /drivers/soc/imx/imx8m-blk-ctrl.c | |
| parent | 926e57c065dfcf5a824b206760330f32e786dd8c (diff) | |
| download | linux-72949f76565c9ea9f4231c977774a31d4713c386.tar.xz | |
soc: imx: imx8m-blk-ctrl: off by one in imx8m_blk_ctrl_xlate()
The > comparison should be >= to prevent reading one element beyond the
end of the array. The onecell_data->domains[] array is allocated in
imx8m_blk_ctrl_probe() and it has "onecell_data->num_domains" elements.
Fixes: 5b340e7813d4 ("soc: imx: add i.MX8M blk-ctrl driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
Diffstat (limited to 'drivers/soc/imx/imx8m-blk-ctrl.c')
| -rw-r--r-- | drivers/soc/imx/imx8m-blk-ctrl.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/soc/imx/imx8m-blk-ctrl.c b/drivers/soc/imx/imx8m-blk-ctrl.c index e172d295c441..519b3651d1d9 100644 --- a/drivers/soc/imx/imx8m-blk-ctrl.c +++ b/drivers/soc/imx/imx8m-blk-ctrl.c @@ -139,7 +139,7 @@ imx8m_blk_ctrl_xlate(struct of_phandle_args *args, void *data) unsigned int index = args->args[0]; if (args->args_count != 1 || - index > onecell_data->num_domains) + index >= onecell_data->num_domains) return ERR_PTR(-EINVAL); return onecell_data->domains[index]; |