diff options
| author | Bart Van Assche <bvanassche@acm.org> | 2019-11-02 00:14:47 +0300 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2019-11-02 03:28:03 +0300 |
| commit | b1335f5b0486f61fb66b123b40f8e7a98e49605d (patch) | |
| tree | edf003596a36439dddf3d7c441349a4415b3a247 /drivers/scsi/fnic/fnic_scsi.c | |
| parent | 64dc4f346b5be50a96f41d628e88c0fdb0ee0254 (diff) | |
| download | linux-b1335f5b0486f61fb66b123b40f8e7a98e49605d.tar.xz | |
scsi: core: scsi_trace: Use get_unaligned_be*()
This patch fixes an unintended sign extension on left shifts. From Colin
King: "Shifting a u8 left will cause the value to be promoted to an
integer. If the top bit of the u8 is set then the following conversion to
an u64 will sign extend the value causing the upper 32 bits to be set in
the result."
Fix this by using get_unaligned_be*() instead.
Fixes: bf8162354233 ("[SCSI] add scsi trace core functions and put trace points")
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.com>
Cc: Douglas Gilbert <dgilbert@interlog.com>
Link: https://lore.kernel.org/r/20191101211447.187151-1-bvanassche@acm.org
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/scsi/fnic/fnic_scsi.c')
0 files changed, 0 insertions, 0 deletions