diff options
| author | Julian Wiedmann <jwi@linux.ibm.com> | 2021-10-25 12:56:53 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-10-25 15:58:19 +0300 |
| commit | fdd3c5f076b69cba2e53e00d9b5191724c7d62f3 (patch) | |
| tree | 255e9a01defc7fbc3a229cb28f25762f841b4bce /drivers/s390/net | |
| parent | a18c28f0aeeb0f03c7176cd328c7b79e9f8e59e9 (diff) | |
| download | linux-fdd3c5f076b69cba2e53e00d9b5191724c7d62f3.tar.xz | |
s390/qeth: clarify remaining dev_kfree_skb_any() users
For none of the users we are under risk of running in HW IRQ context or
or with IRQs disabled. Thus we always end up in consume_skb().
But the two occurences in the RX path should really report the dropped
packet to dropmon, so have them use kfree_skb() instead. That's also
consistent with what napi_free_frags() does internally.
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/s390/net')
| -rw-r--r-- | drivers/s390/net/qeth_core_main.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/s390/net/qeth_core_main.c b/drivers/s390/net/qeth_core_main.c index 48dea62bdaa4..d6230e4e8b1c 100644 --- a/drivers/s390/net/qeth_core_main.c +++ b/drivers/s390/net/qeth_core_main.c @@ -2630,7 +2630,7 @@ static void qeth_free_qdio_queues(struct qeth_card *card) qeth_free_cq(card); for (j = 0; j < QDIO_MAX_BUFFERS_PER_Q; ++j) { if (card->qdio.in_q->bufs[j].rx_skb) - dev_kfree_skb_any(card->qdio.in_q->bufs[j].rx_skb); + consume_skb(card->qdio.in_q->bufs[j].rx_skb); } qeth_free_qdio_queue(card->qdio.in_q); card->qdio.in_q = NULL; @@ -5606,7 +5606,7 @@ static void qeth_receive_skb(struct qeth_card *card, struct sk_buff *skb, if (uses_frags) napi_free_frags(napi); else - dev_kfree_skb_any(skb); + kfree_skb(skb); return; } @@ -5797,7 +5797,7 @@ walk_packet: if (uses_frags) napi_free_frags(napi); else - dev_kfree_skb_any(skb); + kfree_skb(skb); QETH_CARD_STAT_INC(card, rx_length_errors); } |