diff options
| author | Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com> | 2021-04-05 14:43:26 +0300 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2021-04-14 12:19:36 +0300 |
| commit | 9cf37cec4b7d2cb972ba1682dd5c8f39a5761129 (patch) | |
| tree | 8a22a4d2dc2a9d378a18e834b6ff31009b7a7b16 /drivers/regulator/rohm-regulator.c | |
| parent | 703b288f3edf7b08d256499802fba88df5032d53 (diff) | |
| download | linux-9cf37cec4b7d2cb972ba1682dd5c8f39a5761129.tar.xz | |
regulator: rohm-regulator: linear voltage support
The helper for obtaining HW-state based DVS voltage levels currently only
works for regulators using linear-ranges. Extend support to regulators with
simple linear mappings and add also proper error path if pickable-ranges
regulators call this.
Signed-off-by: Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>
Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Diffstat (limited to 'drivers/regulator/rohm-regulator.c')
| -rw-r--r-- | drivers/regulator/rohm-regulator.c | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/drivers/regulator/rohm-regulator.c b/drivers/regulator/rohm-regulator.c index 5c558b153d55..63aabb8c7786 100644 --- a/drivers/regulator/rohm-regulator.c +++ b/drivers/regulator/rohm-regulator.c @@ -22,13 +22,26 @@ static int set_dvs_level(const struct regulator_desc *desc, return ret; return 0; } - + /* If voltage is set to 0 => disable */ if (uv == 0) { if (omask) return regmap_update_bits(regmap, oreg, omask, 0); } + /* Some setups don't allow setting own voltage but do allow enabling */ + if (!mask) { + if (omask) + return regmap_update_bits(regmap, oreg, omask, omask); + + return -EINVAL; + } for (i = 0; i < desc->n_voltages; i++) { - ret = regulator_desc_list_voltage_linear_range(desc, i); + /* NOTE to next hacker - Does not support pickable ranges */ + if (desc->linear_range_selectors) + return -EINVAL; + if (desc->n_linear_ranges) + ret = regulator_desc_list_voltage_linear_range(desc, i); + else + ret = regulator_desc_list_voltage_linear(desc, i); if (ret < 0) continue; if (ret == uv) { |