diff options
author | Michael Chan <michael.chan@broadcom.com> | 2021-10-25 12:05:28 +0300 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2021-10-25 17:58:01 +0300 |
commit | 0c57eeecc559ca6bc18b8c4e2808bc78dbe769b0 (patch) | |
tree | d079961c19187a4aa0fa034c0082638a41fd852d /drivers/power/supply/max8903_charger.c | |
parent | ace19b992436a257d9a793672e57abc28fe83e2e (diff) | |
download | linux-0c57eeecc559ca6bc18b8c4e2808bc78dbe769b0.tar.xz |
net: Prevent infinite while loop in skb_tx_hash()
Drivers call netdev_set_num_tc() and then netdev_set_tc_queue()
to set the queue count and offset for each TC. So the queue count
and offset for the TCs may be zero for a short period after dev->num_tc
has been set. If a TX packet is being transmitted at this time in the
code path netdev_pick_tx() -> skb_tx_hash(), skb_tx_hash() may see
nonzero dev->num_tc but zero qcount for the TC. The while loop that
keeps looping while hash >= qcount will not end.
Fix it by checking the TC's qcount to be nonzero before using it.
Fixes: eadec877ce9c ("net: Add support for subordinate traffic classes to netdev_pick_tx")
Reviewed-by: Andy Gospodarek <gospo@broadcom.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/power/supply/max8903_charger.c')
0 files changed, 0 insertions, 0 deletions