diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2022-03-07 17:18:32 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2022-03-08 18:33:30 +0300 |
| commit | d713b8d2aa03454e676fbf453b1231c43033c33d (patch) | |
| tree | b4ac5f524ab9646f2bf802691839d04a44d86784 /drivers/platform | |
| parent | f2a6c7e7474001842a4adaf042d12206c27fc391 (diff) | |
| download | linux-d713b8d2aa03454e676fbf453b1231c43033c33d.tar.xz | |
platform/x86: amd-pmc: uninitialized variable in amd_pmc_s2d_init()
The "size" variable can be uninitialized if amd_pmc_send_cmd() fails.
Fixes: 3d7d407dfb05 ("platform/x86: amd-pmc: Add support for AMD Spill to DRAM STB feature")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220307141832.GA19660@kili
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform')
| -rw-r--r-- | drivers/platform/x86/amd-pmc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c index 425a86108f75..fc0b4d628dec 100644 --- a/drivers/platform/x86/amd-pmc.c +++ b/drivers/platform/x86/amd-pmc.c @@ -708,8 +708,9 @@ static const struct pci_device_id pmc_pci_ids[] = { static int amd_pmc_s2d_init(struct amd_pmc_dev *dev) { - u32 size, phys_addr_low, phys_addr_hi; + u32 phys_addr_low, phys_addr_hi; u64 stb_phys_addr; + u32 size = 0; /* Spill to DRAM feature uses separate SMU message port */ dev->msg_port = 1; |