diff options
| author | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2021-10-13 19:12:31 +0300 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2021-10-19 17:55:53 +0300 |
| commit | 7c7ba5de7f534c4b563b4add4d430b2186f7ed17 (patch) | |
| tree | ea0b087a684b688c53f2da799459554db6e8b663 /drivers/platform/surface | |
| parent | 5558871360f3fed77b432e9257f3bf90fca7580e (diff) | |
| download | linux-7c7ba5de7f534c4b563b4add4d430b2186f7ed17.tar.xz | |
surface: surface3_power: Drop redundant acpi_bus_get_device() call
If the ACPI companion of a given device is not present, the result
of the ACPI_HANDLE() evaluation for it will be NULL, so calling
acpi_bus_get_device() on ACPI_HANDLE() result in order to validate
it is redundant.
Drop the redundant acpi_bus_get_device() call from mshw0011_notify()
along with a local variable related to it.
No intentional functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/3160001.aeNJFYEL58@kreacher
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'drivers/platform/surface')
| -rw-r--r-- | drivers/platform/surface/surface3_power.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/platform/surface/surface3_power.c b/drivers/platform/surface/surface3_power.c index 90c1568ea4e0..abac3eec565e 100644 --- a/drivers/platform/surface/surface3_power.c +++ b/drivers/platform/surface/surface3_power.c @@ -159,12 +159,11 @@ mshw0011_notify(struct mshw0011_data *cdata, u8 arg1, u8 arg2, unsigned int *ret_value) { union acpi_object *obj; - struct acpi_device *adev; acpi_handle handle; unsigned int i; handle = ACPI_HANDLE(&cdata->adp1->dev); - if (!handle || acpi_bus_get_device(handle, &adev)) + if (!handle) return -ENODEV; obj = acpi_evaluate_dsm_typed(handle, &mshw0011_guid, arg1, arg2, NULL, |