diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2017-06-30 09:57:39 +0300 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2017-06-30 16:46:38 +0300 |
| commit | ea4083165fbb322b69a59588a283b7c98bd42db3 (patch) | |
| tree | ff1b5fb36d66d81ba1ffa27e173d7d82f3ecb75c /drivers/pinctrl/pinctrl-rza1.c | |
| parent | d2a2c80815edfeecb189e6fbef8c2f2421018568 (diff) | |
| download | linux-ea4083165fbb322b69a59588a283b7c98bd42db3.tar.xz | |
pinctrl: rza1: Remove unneeded wrong check for wrong variable
Depending on compiler version:
drivers/pinctrl/pinctrl-rza1.c: In function ‘rza1_pinctrl_probe’:
drivers/pinctrl/pinctrl-rza1.c:1260:5: warning: ‘ret’ may be used uninitialized in this function [-Wmaybe-uninitialized]
if (ret)
^
Indeed, the result returned by platform_get_resource() was stored in
"res", not "ret". In addition, the correct error check would be
"if (!res)", as platform_get_resource() does not return an error code,
but returns NULL on failure.
However, as devm_ioremap_resource() verifies the validity of the passed
resource pointer anyway, the check can just be removed.
Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
Fixes: 5a49b644b3075f88 ("pinctrl: Renesas RZ/A1 pin and gpio controller")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-rza1.c')
| -rw-r--r-- | drivers/pinctrl/pinctrl-rza1.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/pinctrl/pinctrl-rza1.c b/drivers/pinctrl/pinctrl-rza1.c index 614a043f3038..1188e6881e52 100644 --- a/drivers/pinctrl/pinctrl-rza1.c +++ b/drivers/pinctrl/pinctrl-rza1.c @@ -1257,9 +1257,6 @@ static int rza1_pinctrl_probe(struct platform_device *pdev) rza1_pctl->dev = &pdev->dev; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (ret) - return -ENODEV; - rza1_pctl->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(rza1_pctl->base)) return PTR_ERR(rza1_pctl->base); |