diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2015-12-21 19:39:46 +0300 |
---|---|---|
committer | Linus Walleij <linus.walleij@linaro.org> | 2015-12-22 15:45:53 +0300 |
commit | d0b3ed4160201930b505ed9dedc4f80780ad4ff1 (patch) | |
tree | 9c24d7717d8d3422f628abb11d70ac648468d4af /drivers/pinctrl/pinctrl-rockchip.c | |
parent | 2d98023c16048dc59aa54514b4b52da61aa66b13 (diff) | |
download | linux-d0b3ed4160201930b505ed9dedc4f80780ad4ff1.tar.xz |
pinctrl: sh-pfc: add missing of_node_put
for_each_child_of_node performs an of_node_get on each iteration, so a
goto out of the loop requires an of_node_put.
A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):
// <smpl>
@@
local idexpression n;
expression e,e1;
identifier l;
@@
for_each_child_of_node(e1,n) {
...
(
of_node_put(n);
|
e = n
|
return n;
|
+ of_node_put(n);
? goto l;
)
...
}
l: ... when != n
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Diffstat (limited to 'drivers/pinctrl/pinctrl-rockchip.c')
0 files changed, 0 insertions, 0 deletions