diff options
| author | Wei Yongjun <yongjun_wei@trendmicro.com.cn> | 2015-01-14 04:10:00 +0300 |
|---|---|---|
| committer | Kishon Vijay Abraham I <kishon@ti.com> | 2015-01-21 12:53:06 +0300 |
| commit | 147fd9d6bbb6b4bf1c320089494c0cb1bf1636a2 (patch) | |
| tree | 5e066fe2fbbaac34aab8a90a8cd35848e960e7de /drivers/phy | |
| parent | 7f33912d2978796662473f1f5e1fcfc387717e15 (diff) | |
| download | linux-147fd9d6bbb6b4bf1c320089494c0cb1bf1636a2.tar.xz | |
phy: fix return value check in armada375_usb_phy_probe()
In case of error, the function devm_ioremap_resource() returns
ERR_PTR() and never returns NULL. The NULL test in the return
value check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
Diffstat (limited to 'drivers/phy')
| -rw-r--r-- | drivers/phy/phy-armada375-usb2.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/phy/phy-armada375-usb2.c b/drivers/phy/phy-armada375-usb2.c index ac7d99d01cb3..7c99ca256f05 100644 --- a/drivers/phy/phy-armada375-usb2.c +++ b/drivers/phy/phy-armada375-usb2.c @@ -118,8 +118,8 @@ static int armada375_usb_phy_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); usb_cluster_base = devm_ioremap_resource(&pdev->dev, res); - if (!usb_cluster_base) - return -ENOMEM; + if (IS_ERR(usb_cluster_base)) + return PTR_ERR(usb_cluster_base); phy = devm_phy_create(dev, NULL, &armada375_usb_phy_ops); if (IS_ERR(phy)) { |