diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2022-07-09 00:45:39 +0300 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2022-07-12 02:08:23 +0300 |
| commit | 9465a98458fe2a05015bc90d7587fb891cd0c0cc (patch) | |
| tree | 3b2b882918aa5d94d7d5d13820427c218126ea8b /drivers/of | |
| parent | 652081b3c64e03ae3229dd33923d295f9f3115db (diff) | |
| download | linux-9465a98458fe2a05015bc90d7587fb891cd0c0cc.tar.xz | |
of: unittest: make unittest_gpio_remove() consistent with unittest_gpio_probe()
On the ->remove() stage the callback uses physical device node instead of one
from GPIO chip and the variable name which is different to one used in
unittest_gpio_probe(). Make these consistent with unittest_gpio_probe().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20220708214539.7254-2-andriy.shevchenko@linux.intel.com
Diffstat (limited to 'drivers/of')
| -rw-r--r-- | drivers/of/unittest.c | 13 |
1 files changed, 6 insertions, 7 deletions
diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 5a842dfc27e8..eafa8ffefbd0 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -1620,20 +1620,19 @@ static int unittest_gpio_probe(struct platform_device *pdev) static int unittest_gpio_remove(struct platform_device *pdev) { - struct unittest_gpio_dev *gdev = platform_get_drvdata(pdev); + struct unittest_gpio_dev *devptr = platform_get_drvdata(pdev); struct device *dev = &pdev->dev; - struct device_node *np = pdev->dev.of_node; - dev_dbg(dev, "%s for node @%pOF\n", __func__, np); + dev_dbg(dev, "%s for node @%pfw\n", __func__, devptr->chip.fwnode); - if (!gdev) + if (!devptr) return -EINVAL; - if (gdev->chip.base != -1) - gpiochip_remove(&gdev->chip); + if (devptr->chip.base != -1) + gpiochip_remove(&devptr->chip); platform_set_drvdata(pdev, NULL); - kfree(gdev); + kfree(devptr); return 0; } |