diff options
| author | Chaitanya Kulkarni <kch@nvidia.com> | 2022-07-19 02:12:32 +0300 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2022-08-03 02:22:51 +0300 |
| commit | 1040415c29f065e47b6b4df9f3902602d0382d3d (patch) | |
| tree | bed6aab44cec2fe41bff0beecf66696db8af7821 /drivers/nvme | |
| parent | 9db056e9506ccf74405941777ae128947b81900d (diff) | |
| download | linux-1040415c29f065e47b6b4df9f3902602d0382d3d.tar.xz | |
nvmet-auth: fix return value check in auth send
nvmet_setup_auth() return type is int and currently it uses status
variable that is of type u16 in nvmet_execute_auth_send().
Catch the return value of nvmet_setup_auth() into int and set the
NVME_SC_INTERNAL as status variable before we jump to error.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/nvme')
| -rw-r--r-- | drivers/nvme/target/fabrics-cmd-auth.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/nvme/target/fabrics-cmd-auth.c b/drivers/nvme/target/fabrics-cmd-auth.c index cc56e8c821ce..b785a8e27fa0 100644 --- a/drivers/nvme/target/fabrics-cmd-auth.c +++ b/drivers/nvme/target/fabrics-cmd-auth.c @@ -247,8 +247,8 @@ void nvmet_execute_auth_send(struct nvmet_req *req) pr_debug("%s: ctrl %d qid %d reset negotiation\n", __func__, ctrl->cntlid, req->sq->qid); if (!req->sq->qid) { - status = nvmet_setup_auth(ctrl); - if (status < 0) { + if (nvmet_setup_auth(ctrl) < 0) { + status = NVME_SC_INTERNAL; pr_err("ctrl %d qid 0 failed to setup" "re-authentication", ctrl->cntlid); |