diff options
| author | Tvrtko Ursulin <tvrtko.ursulin@intel.com> | 2016-12-16 16:18:42 +0300 |
|---|---|---|
| committer | Tvrtko Ursulin <tvrtko.ursulin@intel.com> | 2016-12-16 17:30:00 +0300 |
| commit | d038fc7e4fff14d6b026130007faef35cbf5e956 (patch) | |
| tree | 488559e72ea00bc332837b7409b63c8f26a4abbb /drivers/nvdimm/pmem.h | |
| parent | 15a43cbf4736a3932e6259fa7d6e47558f6222b0 (diff) | |
| download | linux-d038fc7e4fff14d6b026130007faef35cbf5e956.tar.xz | |
drm/i915: Fix use after free in logical_render_ring_init
Commit 3b3f1650b1ca ("drm/i915: Allocate intel_engine_cs
structure only for the enabled engines") introduced the
dynanically allocated engine instances and created an
potential use after free scenario in logical_render_ring_init
where lrc_destroy_wa_ctx_obj could be called after the engine
instance has been freed.
This can only happen during engine setup/init error handling
which luckily does not happen ever in practice.
Fix is to not call lrc_destroy_wa_ctx_obj since it would have
already been executed from the preceding engine cleanup.
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 3b3f1650b1ca ("drm/i915: Allocate intel_engine_cs structure only for the enabled engines")
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Daniel Vetter <daniel.vetter@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/1481894322-2145-1-git-send-email-tvrtko.ursulin@linux.intel.com
Diffstat (limited to 'drivers/nvdimm/pmem.h')
0 files changed, 0 insertions, 0 deletions