diff options
| author | Ruan Jinjie <ruanjinjie@huawei.com> | 2023-08-17 09:32:19 +0300 |
|---|---|---|
| committer | Jon Mason <jdmason@kudzu.us> | 2023-08-18 16:50:06 +0300 |
| commit | 28e70ed9d0fab935f78b565d9c026585559b86a4 (patch) | |
| tree | f4301cdfc2d79411359f89571e12973a90921480 /drivers/ntb/hw/amd | |
| parent | 03c9e6f0e0ab3fb6129b8a9f064b7d7957aa969a (diff) | |
| download | linux-28e70ed9d0fab935f78b565d9c026585559b86a4.tar.xz | |
ntb: amd: Drop unnecessary error check for debugfs_create_dir
This patch removes the error checking for debugfs_create_dir in
ntb_hw_amd.c. This is because the DebugFS kernel API is developed
in a way that the caller can safely ignore the errors that
occur during the creation of DebugFS nodes. The debugfs APIs have
a IS_ERR() judge in start_creating() which can handle it
gracefully. so these checks are unnecessary.
Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Acked-by: Sanjay R Mehta <sanju.mehta@amd.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers/ntb/hw/amd')
| -rw-r--r-- | drivers/ntb/hw/amd/ntb_hw_amd.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/drivers/ntb/hw/amd/ntb_hw_amd.c b/drivers/ntb/hw/amd/ntb_hw_amd.c index 4940b6301d83..d687e8c2cc78 100644 --- a/drivers/ntb/hw/amd/ntb_hw_amd.c +++ b/drivers/ntb/hw/amd/ntb_hw_amd.c @@ -941,13 +941,10 @@ static void ndev_init_debugfs(struct amd_ntb_dev *ndev) ndev->debugfs_dir = debugfs_create_dir(pci_name(ndev->ntb.pdev), debugfs_dir); - if (IS_ERR(ndev->debugfs_dir)) - ndev->debugfs_info = NULL; - else - ndev->debugfs_info = - debugfs_create_file("info", S_IRUSR, - ndev->debugfs_dir, ndev, - &amd_ntb_debugfs_info); + ndev->debugfs_info = + debugfs_create_file("info", S_IRUSR, + ndev->debugfs_dir, ndev, + &amd_ntb_debugfs_info); } } |