diff options
| author | Jean Sacren <sakiwit@gmail.com> | 2021-10-06 09:41:20 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-10-06 17:17:28 +0300 |
| commit | fe5d8bd3d3ea7422b8ae8f1863ac2ab06998947a (patch) | |
| tree | 7931449b4fd6faceeca92d921795c5e9551dfcf6 /drivers/net | |
| parent | 6c601aac4976531ccfbda74e04ef9bf3626f205e (diff) | |
| download | linux-fe5d8bd3d3ea7422b8ae8f1863ac2ab06998947a.tar.xz | |
net: tg3: fix obsolete check of !err
The err variable is checked for true or false a few lines above. When
!err is checked again, it always evaluates to true. Therefore we should
skip this check.
We should also group the adjacent statements together for readability.
Signed-off-by: Jean Sacren <sakiwit@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net')
| -rw-r--r-- | drivers/net/ethernet/broadcom/tg3.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c index d95b11480865..5a50ea75094f 100644 --- a/drivers/net/ethernet/broadcom/tg3.c +++ b/drivers/net/ethernet/broadcom/tg3.c @@ -11213,12 +11213,8 @@ static void tg3_reset_task(struct work_struct *work) } tg3_netif_start(tp); - tg3_full_unlock(tp); - - if (!err) - tg3_phy_start(tp); - + tg3_phy_start(tp); tg3_flag_clear(tp, RESET_TASK_PENDING); out: rtnl_unlock(); |