diff options
| author | Yan-Hsuan Chuang <yhchuang@realtek.com> | 2019-10-02 05:31:19 +0300 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2019-10-02 07:33:41 +0300 |
| commit | 61d7309562b51e9600f69ca70f9edf71f841fee7 (patch) | |
| tree | af1a1b96e2fc190f6347f98d46973958ca3d7980 /drivers/net/wireless/realtek/rtw88/tx.c | |
| parent | 6f0b0d28fde849a404f4b307887405e326866e11 (diff) | |
| download | linux-61d7309562b51e9600f69ca70f9edf71f841fee7.tar.xz | |
rtw88: not to enter or leave PS under IRQ
Remove PS related *_irqsafe functions to avoid entering/leaving PS
under interrupt context. Instead, make PS decision in watch_dog.
This could simplify the logic and make the code look clean.
But it could have a little side-effect that if the driver is having
heavy traffic before the every-2-second watch_dog detect the traffic
and decide to leave PS, the thoughput will be lower. Once traffic is
detected by watch_dog and left PS state, the throughput will resume
to the peak the hardware ought to have again.
Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/net/wireless/realtek/rtw88/tx.c')
| -rw-r--r-- | drivers/net/wireless/realtek/rtw88/tx.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/net/wireless/realtek/rtw88/tx.c b/drivers/net/wireless/realtek/rtw88/tx.c index 8eaa9809ca44..91bfd8c28ff7 100644 --- a/drivers/net/wireless/realtek/rtw88/tx.c +++ b/drivers/net/wireless/realtek/rtw88/tx.c @@ -27,8 +27,6 @@ void rtw_tx_stats(struct rtw_dev *rtwdev, struct ieee80211_vif *vif, rtwvif = (struct rtw_vif *)vif->drv_priv; rtwvif->stats.tx_unicast += skb->len; rtwvif->stats.tx_cnt++; - if (rtwvif->stats.tx_cnt > RTW_LPS_THRESHOLD) - rtw_leave_lps_irqsafe(rtwdev, rtwvif); } } } |