diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2021-11-23 04:24:47 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-11-23 15:18:48 +0300 |
| commit | 2106efda785b55a8957efed9a52dfa28ee0d7280 (patch) | |
| tree | 12e5c191146b24614bae365a3fd3bc414c485607 /drivers/net/vxlan.c | |
| parent | c384cee14aa330ba2f5616fb821ba81f2ef42ccd (diff) | |
| download | linux-2106efda785b55a8957efed9a52dfa28ee0d7280.tar.xz | |
net: remove .ndo_change_proto_down
.ndo_change_proto_down was added seemingly to enable out-of-tree
implementations. Over 2.5yrs later we still have no real users
upstream. Hardwire the generic implementation for now, we can
revert once real users materialize. (rocker is a test vehicle,
not a user.)
We need to drop the optimization on the sysfs side, because
unlike ndos priv_flags will be changed at runtime, so we'd
need READ_ONCE/WRITE_ONCE everywhere..
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/vxlan.c')
| -rw-r--r-- | drivers/net/vxlan.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 82bd794fceb3..fecff0a46612 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -3234,7 +3234,6 @@ static const struct net_device_ops vxlan_netdev_ether_ops = { .ndo_fdb_dump = vxlan_fdb_dump, .ndo_fdb_get = vxlan_fdb_get, .ndo_fill_metadata_dst = vxlan_fill_metadata_dst, - .ndo_change_proto_down = dev_change_proto_down_generic, }; static const struct net_device_ops vxlan_netdev_raw_ops = { @@ -3305,7 +3304,7 @@ static void vxlan_setup(struct net_device *dev) dev->hw_features |= NETIF_F_RXCSUM; dev->hw_features |= NETIF_F_GSO_SOFTWARE; netif_keep_dst(dev); - dev->priv_flags |= IFF_NO_QUEUE; + dev->priv_flags |= IFF_NO_QUEUE | IFF_CHANGE_PROTO_DOWN; /* MTU range: 68 - 65535 */ dev->min_mtu = ETH_MIN_MTU; |