diff options
author | Remi Pommarel <repk@triplefau.lt> | 2021-12-23 18:31:38 +0300 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2021-12-23 20:53:50 +0300 |
commit | d95a56207c078e2019cf6659d890ec1e987e8420 (patch) | |
tree | 82e9c1ec718f565567328f5da6586fea6f0a9e65 /drivers/net/usb/r8152.c | |
parent | eccffcf4657ab9a148faaa0eb354d2a091caf552 (diff) | |
download | linux-d95a56207c078e2019cf6659d890ec1e987e8420.tar.xz |
net: bridge: fix ioctl old_deviceless bridge argument
Commit 561d8352818f ("bridge: use ndo_siocdevprivate") changed the
source and destination arguments of copy_{to,from}_user in bridge's
old_deviceless() from args[1] to uarg breaking SIOC{G,S}IFBR ioctls.
Commit cbd7ad29a507 ("net: bridge: fix ioctl old_deviceless bridge
argument") fixed only BRCTL_{ADD,DEL}_BRIDGES commands leaving
BRCTL_GET_BRIDGES one untouched.
The fixes BRCTL_GET_BRIDGES as well and has been tested with busybox's
brctl.
Example of broken brctl:
$ brctl show
bridge name bridge id STP enabled interfaces
brctl: can't get bridge name for index 0: No such device or address
Example of fixed brctl:
$ brctl show
bridge name bridge id STP enabled interfaces
br0 8000.000000000000 no
Fixes: 561d8352818f ("bridge: use ndo_siocdevprivate")
Signed-off-by: Remi Pommarel <repk@triplefau.lt>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Nikolay Aleksandrov <nikolay@nvidia.com>
Link: https://lore.kernel.org/all/20211223153139.7661-2-repk@triplefau.lt/
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers/net/usb/r8152.c')
0 files changed, 0 insertions, 0 deletions