summaryrefslogtreecommitdiff
path: root/drivers/net/tulip
diff options
context:
space:
mode:
authorStephen Hemminger <shemminger@linux-foundation.org>2008-01-07 11:23:04 +0300
committerDavid S. Miller <davem@davemloft.net>2008-01-09 10:30:01 +0300
commitc6a1b62de9d043f274ec3ae2e207908c6d5feff3 (patch)
tree4546e2a0b4fcea21c30bca1e60f6b81af62c7d7c /drivers/net/tulip
parentedba2a1fefc6296bc527754dee1c72a625bb675a (diff)
downloadlinux-c6a1b62de9d043f274ec3ae2e207908c6d5feff3.tar.xz
[TULIP]: NAPI full quantum bug.
This should fix the kernel warn/oops reported while routing. The tulip driver has a fencepost bug with new NAPI in 2.6.24 It has an off by one bug if a full quantum is reached. Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/tulip')
-rw-r--r--drivers/net/tulip/interrupt.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/net/tulip/interrupt.c b/drivers/net/tulip/interrupt.c
index 365331446387..0461956d3b50 100644
--- a/drivers/net/tulip/interrupt.c
+++ b/drivers/net/tulip/interrupt.c
@@ -151,7 +151,8 @@ int tulip_poll(struct napi_struct *napi, int budget)
if (tulip_debug > 5)
printk(KERN_DEBUG "%s: In tulip_rx(), entry %d %8.8x.\n",
dev->name, entry, status);
- if (work_done++ >= budget)
+
+ if (++work_done >= budget)
goto not_done;
if ((status & 0x38008300) != 0x0300) {