diff options
| author | Steve Hodgson <shodgson@solarflare.com> | 2009-12-23 16:46:36 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2009-12-24 06:09:04 +0300 |
| commit | ff3b00a0fcaab89ff885e9f0f4ad83c4ced788f4 (patch) | |
| tree | a9bede7f0b4552a00add40bdfb21f3f9e5c4e9b7 /drivers/net/sfc/siena.c | |
| parent | ed4b2019a62e2208a8370461dd91ed4de2c9fc8f (diff) | |
| download | linux-ff3b00a0fcaab89ff885e9f0f4ad83c4ced788f4.tar.xz | |
sfc: Move PHY software state initialisation from init() into probe()
This prevents efx->link_advertising from being blatted during
a reset.
The phy_short_reach sysfs node is now destroyed later in the
port shutdown process, so check for STATE_RUNNING after
acquiring the rtnl_lock (just like in set_phy_flash_cfg).
Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/sfc/siena.c')
| -rw-r--r-- | drivers/net/sfc/siena.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/net/sfc/siena.c b/drivers/net/sfc/siena.c index de07a4f031b2..f8c6771e66d8 100644 --- a/drivers/net/sfc/siena.c +++ b/drivers/net/sfc/siena.c @@ -133,6 +133,7 @@ static int siena_probe_port(struct efx_nic *efx) void siena_remove_port(struct efx_nic *efx) { + efx->phy_op->remove(efx); efx_nic_free_buffer(efx, &efx->stats_buffer); } |