diff options
author | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2015-04-03 23:27:14 +0300 |
---|---|---|
committer | Jeff Kirsher <jeffrey.t.kirsher@intel.com> | 2015-04-15 01:56:35 +0300 |
commit | da61b36706f06a95bedeef0168db5b40a2940f8a (patch) | |
tree | 51771f5f1ec2b2aa50fe93df6959d2b6d28a1371 /drivers/net/ppp/ppp_async.c | |
parent | 78288e3750c568f0f95db235a06475db3b1a122a (diff) | |
download | linux-da61b36706f06a95bedeef0168db5b40a2940f8a.tar.xz |
fm10k: mbx_update_max_size does not drop all oversized messages
When we call update_max_size it does not drop all oversized messages.
This is due to the difficulty in performing this operation, since it is
a FIFO which makes updating anything other than head or tail very
difficult. To fix this, modify validate_msg_size to ensure that we error
out later when trying to transmit the message that could be oversized.
This will generally be a rare condition, as it requires the FIFO to
include a message larger than the max_size negotiated during mailbox
connect. Note that max_size is always smaller than rx.size so it should
be safe to use here.
Also, update the update_max_size function header comment to clearly
indicate that it does not drop all oversized messages, but only those at
the head of the FIFO.
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Acked-by: Matthew Vick <matthew.vick@intel.com>
Tested-by: Krishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Diffstat (limited to 'drivers/net/ppp/ppp_async.c')
0 files changed, 0 insertions, 0 deletions