diff options
| author | Thomas Tai <thomas.tai@oracle.com> | 2017-05-15 20:51:07 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-05-15 22:36:08 +0300 |
| commit | b18e5e86b44be0dca399d8e2383f97c8077392ce (patch) | |
| tree | 6d149c41a4d8f9d1a6912c69f9678737812e7b0f /drivers/net/ethernet/sun/ldmvsw.c | |
| parent | ca9df7ede41afd006d74fd6f09f36d909d0eaad7 (diff) | |
| download | linux-b18e5e86b44be0dca399d8e2383f97c8077392ce.tar.xz | |
ldmvsw: unregistering netdev before disable hardware
When running LDom binding/unbinding test, kernel may panic
in ldmvsw_open(). It is more likely that because we're removing
the ldc connection before unregistering the netdev in vsw_port_remove(),
we set up a window of time where one process could be removing the
device while another trying to UP the device. This also sometimes causes
vio handshake error due to opening a device without closing it completely.
We should unregister the netdev before we disable the "hardware".
Orabug: 25980913, 25925306
Signed-off-by: Thomas Tai <thomas.tai@oracle.com>
Signed-off-by: Shannon Nelson <shannon.nelson@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/ethernet/sun/ldmvsw.c')
| -rw-r--r-- | drivers/net/ethernet/sun/ldmvsw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/sun/ldmvsw.c b/drivers/net/ethernet/sun/ldmvsw.c index 5a90fed06260..309747c7b8ae 100644 --- a/drivers/net/ethernet/sun/ldmvsw.c +++ b/drivers/net/ethernet/sun/ldmvsw.c @@ -413,6 +413,7 @@ static int vsw_port_remove(struct vio_dev *vdev) del_timer_sync(&port->vio.timer); napi_disable(&port->napi); + unregister_netdev(port->dev); list_del_rcu(&port->list); @@ -427,7 +428,6 @@ static int vsw_port_remove(struct vio_dev *vdev) dev_set_drvdata(&vdev->dev, NULL); - unregister_netdev(port->dev); free_netdev(port->dev); } |